From: Mike Frysinger Date: Thu, 17 Dec 2009 17:34:33 -0500 Subject: [U-Boot] [PATCH 07/25] Blackfin: do not require CONFIG_BAUDRATE In-Reply-To: <20091217213238.98511D43F21@gemini.denx.de> References: <1261017850-22802-1-git-send-email-vapier@gentoo.org> <1261017850-22802-8-git-send-email-vapier@gentoo.org> <20091217213238.98511D43F21@gemini.denx.de> Message-ID: <200912171734.34098.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 17 December 2009 16:32:38 Wolfgang Denk wrote: > Mike Frysinger wrote: > > Signed-off-by: Mike Frysinger > > --- > > cpu/blackfin/initcode.c | 3 +++ > > lib_blackfin/board.c | 2 ++ > > 2 files changed, 5 insertions(+), 0 deletions(-) > > ... > > > static int init_baudrate(void) > > { > > +#ifdef CONFIG_BAUDRATE > > char baudrate[15]; > > int i = getenv_r("baudrate", baudrate, sizeof(baudrate)); > > gd->bd->bi_baudrate = gd->baudrate = (i > 0) > > ? simple_strtoul(baudrate, NULL, 10) > > > > : CONFIG_BAUDRATE; > > > > +#endif > > return 0; > > } > > Out of curiosity: what do these boards do when CONFIG_BAUDRATE is not > defined? the boards lack serial and/or dont use it. they're controlled via JTAG. > It seems yo me you add a new, additional meaning to the > CONFIG_BAUDRATE option here. This should be documented (at least in > the README). i could just fall back to a value of 0 ... there'd be a little more useless code added, but not much to be done here seeing as how the rest of u-boot assumes baudrate is usable. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20091217/589d84bc/attachment.pgp