From: Wolfgang Denk Date: Thu, 17 Dec 2009 22:32:38 +0100 Subject: [U-Boot] [PATCH 07/25] Blackfin: do not require CONFIG_BAUDRATE In-Reply-To: <1261017850-22802-8-git-send-email-vapier@gentoo.org> References: <1261017850-22802-1-git-send-email-vapier@gentoo.org> <1261017850-22802-8-git-send-email-vapier@gentoo.org> Message-ID: <20091217213238.98511D43F21@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <1261017850-22802-8-git-send-email-vapier@gentoo.org> you wrote: > Signed-off-by: Mike Frysinger > --- > cpu/blackfin/initcode.c | 3 +++ > lib_blackfin/board.c | 2 ++ > 2 files changed, 5 insertions(+), 0 deletions(-) ... > static int init_baudrate(void) > { > +#ifdef CONFIG_BAUDRATE > char baudrate[15]; > int i = getenv_r("baudrate", baudrate, sizeof(baudrate)); > gd->bd->bi_baudrate = gd->baudrate = (i > 0) > ? simple_strtoul(baudrate, NULL, 10) > : CONFIG_BAUDRATE; > +#endif > return 0; > } Out of curiosity: what do these boards do when CONFIG_BAUDRATE is not defined? It seems yo me you add a new, additional meaning to the CONFIG_BAUDRATE option here. This should be documented (at least in the README). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Time is fluid ... like a river with currents, eddies, backwash. -- Spock, "The City on the Edge of Forever", stardate 3134.0