From: Wolfgang Denk Date: Thu, 17 Dec 2009 22:47:20 +0100 Subject: [U-Boot] [PATCH 25/25] Blackfin: add support for BF527-EZKIT v2.1 In-Reply-To: <1261017850-22802-26-git-send-email-vapier@gentoo.org> References: <1261017850-22802-1-git-send-email-vapier@gentoo.org> <1261017850-22802-26-git-send-email-vapier@gentoo.org> Message-ID: <20091217214720.0A39FD43F21@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <1261017850-22802-26-git-send-email-vapier@gentoo.org> you wrote: > From: Michael Hennerich > > The new board revision has a different LCD. > > Signed-off-by: Michael Hennerich > Signed-off-by: Mike Frysinger > --- > i've removed include/asm-blackfin/bfin_logo_rgb565_230x230.h from the > diffstat since it's so big (120kb) and it's generated output from > easylogo and the Blackfin .tga. Seems you removed it not fromthe diffstat, but from the patch itself? > $(BFIN_BOARDS:%=%_config) : unconfig > - @$(MKCONFIG) $(@:_config=) blackfin blackfin $(@:_config=) > + @$(MKCONFIG) $(MKCONFIG_$(@:_config=)) $(@:_config=) blackfin blackfin $(@:_config=) Line too long. > +#if !(defined(CONFIG_LQ035Q1_USE_RGB888_8_BIT_PPI) || defined(CONFIG_LQ035Q1_USE_RGB565_8_BIT_PPI)) > +#define CONFIG_LQ035Q1_USE_RGB565_8_BIT_PPI > +#endif > + > +/* Interface 16/18-bit TFT over an 8-bit wide PPI using a small Programmable Logic Device (CPLD) > + * http://blackfin.uclinux.org/gf/project/stamp/frs/?action=FrsReleaseBrowse&frs_package_id=165 > + */ Lines too long. Please fix globally. > --- a/include/configs/bf527-ezkit.h > +++ b/include/configs/bf527-ezkit.h > @@ -155,6 +155,15 @@ > > > /* > + * Video Settings > + */ > +#ifdef CONFIG_MK_BF527_EZKIT_REV_2_1 > +# define CONFIG_LQ035Q1_SPI_BUS 0 > +# define CONFIG_LQ035Q1_SPI_CS 7 > +#endif > + > + Please don't add that many empty lines. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Successful and fortunate crime is called virtue. - Seneca