Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NLkx1-0001un-Rq for qemu-devel@nongnu.org; Fri, 18 Dec 2009 17:05:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NLkx0-0001rf-AS for qemu-devel@nongnu.org; Fri, 18 Dec 2009 17:05:31 -0500 Received: from [199.232.76.173] (port=53321 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLkx0-0001r9-2N for qemu-devel@nongnu.org; Fri, 18 Dec 2009 17:05:30 -0500 Received: from hall.aurel32.net ([88.191.82.174]:44945) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NLkx0-0006cC-0X for qemu-devel@nongnu.org; Fri, 18 Dec 2009 17:05:30 -0500 Date: Fri, 18 Dec 2009 23:05:22 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] target-arm: ARMv4 emulation Message-ID: <20091218220522.GM24729@hall.aurel32.net> References: <20091218213237.GA13509@debbook.brain-dump.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20091218213237.GA13509@debbook.brain-dump.org> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc Andre Tanner Cc: vince@kyllikki.org, qemu-devel@nongnu.org, Filip Navara , paul@codesourcery.com On Fri, Dec 18, 2009 at 10:32:37PM +0100, Marc Andre Tanner wrote: > On Tue, Dec 01, 2009 at 09:41:43PM +0100, Filip Navara wrote: > > While most of the ARMv5 instructions are backward compatible with ARMv4, there > > are few important differences. Most notably the stack pop and load instructions > > ignore the lowest bit, which is used by ARMv5 to switch to Thumb mode. A > > base-updated data-abort model is used on ARM7TDMI, CP15 coprocessor is not > > present and several instructions of later architectures are not implemented. > > > > This patch introduces flags for the V5, CP15 and ABORT_BU (base-updated abort > > model) features. When V5 feature is not set the bit 0 on POP, LD and LDM of PC > > register is ignored and doesn't swith to/from Thumb mode and several > > instructions are treated as unimplemented (BLX, PLD, BKPT, LDRD, STRD). > > > > Added are processor definitions for ARM7TDMI and ARM920T. > > > > Based on patches by Ulrich Hecht and Vincent Sanders . > > Could someone please review + apply this patch, bonus points if it ends > up in 0.12. > ARM stuff is usually reviewed by Paul Brook. Paul, do you plan to review it, or should I do it? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net