Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NM1WO-0003ay-0m for qemu-devel@nongnu.org; Sat, 19 Dec 2009 10:47:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NM1WN-0003Zu-BZ for qemu-devel@nongnu.org; Sat, 19 Dec 2009 10:47:07 -0500 Received: from [199.232.76.173] (port=33682 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NM1WN-0003Zb-4l for qemu-devel@nongnu.org; Sat, 19 Dec 2009 10:47:07 -0500 Received: from hall.aurel32.net ([88.191.82.174]:60595) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NM1WM-0007bH-SL for qemu-devel@nongnu.org; Sat, 19 Dec 2009 10:47:07 -0500 Date: Sat, 19 Dec 2009 16:47:04 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] target-alpha: Emit tcg debug_insn_start. Message-ID: <20091219154704.GR24729@hall.aurel32.net> References: <20091218221500.B4C84A46@are.twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20091218221500.B4C84A46@are.twiddle.net> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Wed, Dec 16, 2009 at 06:33:05PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-alpha/translate.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/target-alpha/translate.c b/target-alpha/translate.c > index 45cb697..ceff9bf 100644 > --- a/target-alpha/translate.c > +++ b/target-alpha/translate.c > @@ -2627,6 +2627,10 @@ static inline void gen_intermediate_code_internal(CPUState *env, > gen_io_start(); > insn = ldl_code(ctx.pc); > num_insns++; > + > + if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP))) > + tcg_gen_debug_insn_start(ctx.pc); > + The coding style is wrong, you should use spaces instead of tabs. Also use braces after if. Otherwise it's ok. > ctx.pc += 4; > ret = translate_one(ctxp, insn); > if (ret != 0) > -- > 1.6.5.2 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net