Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NM8zJ-00027U-Kp for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:45:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NM8zI-000278-Q8 for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:45:29 -0500 Received: from [199.232.76.173] (port=53862 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NM8zI-000275-M3 for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:45:28 -0500 Received: from hall.aurel32.net ([88.191.82.174]:39549) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NM8zI-0003oY-9E for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:45:28 -0500 Date: Sun, 20 Dec 2009 00:45:26 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set Message-ID: <20091219234526.GW24729@hall.aurel32.net> References: <08eb5a18dde9c9a676073d179003398473ca311c.1261248772.git.rth@twiddle.net> <20091219231122.GA32752@volta.aurel32.net> <4B2D60A6.6070907@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <4B2D60A6.6070907@twiddle.net> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Sat, Dec 19, 2009 at 03:24:22PM -0800, Richard Henderson wrote: > On 12/19/2009 03:11 PM, Aurelien Jarno wrote: >> On Sat, Dec 19, 2009 at 10:01:57AM -0800, Richard Henderson wrote: >>> Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. >> >> I do wonder if setcond2_i32 and brcond2_i32 should be added there. Those >> are internal ops that are actually not exported in tcg-op.h. > > I think it's probably useful documentation, even if it is internal. > One does have to know what it means in order to implement it in the > backends. > Then we should probably move it into another section, as people also use this doc to know what tcg_gen_* ops are available. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net