Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NQhHQ-0005a4-33 for mharc-grub-devel@gnu.org; Fri, 01 Jan 2010 08:11:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQhHO-0005Zq-Pm for grub-devel@gnu.org; Fri, 01 Jan 2010 08:10:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQhHJ-0005ZG-Sx for grub-devel@gnu.org; Fri, 01 Jan 2010 08:10:58 -0500 Received: from [199.232.76.173] (port=37379 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQhHJ-0005ZD-Og for grub-devel@gnu.org; Fri, 01 Jan 2010 08:10:53 -0500 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:35469 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NQhHJ-0004AU-Gk for grub-devel@gnu.org; Fri, 01 Jan 2010 08:10:53 -0500 Received: from pinux (unknown [192.168.0.78]) by mail.pina.cat (Postfix) with ESMTPA id DE9972894B244 for ; Fri, 1 Jan 2010 14:10:51 +0100 (CET) Received: by pinux (Postfix, from userid 1000) id 791611016C; Fri, 1 Jan 2010 14:10:51 +0100 (CET) Date: Fri, 1 Jan 2010 14:10:51 +0100 From: Carles Pina i Estany To: The development of GNU GRUB Message-ID: <20100101131051.GA23110@pina.cat> References: <20091228011737.GA17321@pina.cat> <20100101122234.GN3692@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100101122234.GN3692@thorin> User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] spaces (label, UUID) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2010 13:10:59 -0000 Hi, On Jan/01/2010, Robert Millan wrote: > On Mon, Dec 28, 2009 at 02:17:37AM +0100, Carles Pina i Estany wrote: > > === modified file 'normal/misc.c' > > --- normal/misc.c 2009-12-20 23:32:15 +0000 > > +++ normal/misc.c 2009-12-28 01:15:34 +0000 > > @@ -68,7 +68,10 @@ grub_normal_print_device_info (const cha > > if (grub_errno == GRUB_ERR_NONE) > > { > > if (label && grub_strlen (label)) > > - grub_printf_ (N_("- Label %s"), label); > > + { > > + grub_putchar (' '); > > + grub_printf_ (N_("- Label \"%s\""), label); > > + } > Why not just add a space before the -? > > Uhm, I guess I know the answer in advance :-) I think that you thought about half of the reasons :-) > Carles, we shouldn't avoid changing translatable strings at the cost > of making the code bigger or less efficient. It's not hard for > translators to reuse the old string. This is half of the reason (and not too bad: this translation will appear as "fuzzy" so it's not everything lost) The other reason: http://lists.gnu.org/archive/html/grub-devel/2009-12/msg00131.html Avoiding to have trailing spaces helps the translators (they will do less mistakes). Of course makes the code slightly bigger (source code and binary) > I notice that you committed it already. Please can you adjust? Yes I can adjust, but could you reconfirm if I should adjust after above message? Thanks, -- Carles Pina i Estany http://pinux.info