From: Pavel Machek Subject: Re: [PATCH 2/3] Security: Implement disablenetwork semantics. (v4) Date: Sun, 10 Jan 2010 22:16:09 +0100 Message-ID: <20100110211609.GC26079@elf.ucw.cz> References: <20091227010441.GA12077@heat> <20091227010650.GA12190@heat> <20091230185053.GB18712@us.ibm.com> <20100101143100.GA3944@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Serge E. Hallyn" , Michael Stone , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, Andi Kleen , David Lang , Oliver Hartkopp , Alan Cox , Herbert Xu , Valdis Kletnieks , Bryan Donlan , Evgeniy Polyakov , "C. Scott Ananian" , "Eric W. Biederman" , Bernie Innocenti , Mark Seaborn , Randy Dunlap , Am?rico Wang , Tetsuo Handa , Samir Bellabes , Casey Schaufler To: James Morris Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-security-module-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon 2010-01-11 08:11:55, James Morris wrote: > On Fri, 1 Jan 2010, Pavel Machek wrote: > > > > Quoting Michael Stone (michael@laptop.org): > > > > Implement security_* hooks for socket_create, socket_bind, socket_connect, > > > > socket_sendmsg, and ptrace_access_check which return -EPERM when called from a > > > > process with networking restrictions. Exempt AF_UNIX sockets. > > > > > > > > Signed-off-by: Michael Stone > > > > > > Acked-by: Serge Hallyn > > > > For the record: NAK, as it introduces security holes. > > Please elaborate. See the mailthread. Allows user to disable suid program's access to network. That bypasses audit, and will cause system-wide DoS if suid program decides to go daemon. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html