Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWVCZ-0005U3-Lg for qemu-devel@nongnu.org; Sun, 17 Jan 2010 08:29:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWVCU-0005PP-Of for qemu-devel@nongnu.org; Sun, 17 Jan 2010 08:29:59 -0500 Received: from [199.232.76.173] (port=45210 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWVCU-0005PI-Jx for qemu-devel@nongnu.org; Sun, 17 Jan 2010 08:29:54 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:48332) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWVCU-0000Ka-3f for qemu-devel@nongnu.org; Sun, 17 Jan 2010 08:29:54 -0500 Date: Sun, 17 Jan 2010 21:13:48 +1300 From: Simon Horman Subject: Re: [Qemu-devel] Re: [PATCH] rtl8139: fix clang reporting unused assignment of VLAN tagging data Message-ID: <20100117081348.GA1984@verge.net.au> References: <20100113225325.6508.46954.stgit@skyserv> <4B501485.3080706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B501485.3080706@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Fri, Jan 15, 2010 at 08:08:53AM +0100, Paolo Bonzini wrote: > > >diff --git a/hw/rtl8139.c b/hw/rtl8139.c > >index 1f4f585..f04dd54 100644 > >--- a/hw/rtl8139.c > >+++ b/hw/rtl8139.c > >@@ -1909,6 +1909,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) > > > > cpu_physical_memory_read(cplus_tx_ring_desc, (uint8_t *)&val, 4); > > txdw0 = le32_to_cpu(val); > >+ /* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */ > > cpu_physical_memory_read(cplus_tx_ring_desc+4, (uint8_t *)&val, 4); > > txdw1 = le32_to_cpu(val); > > cpu_physical_memory_read(cplus_tx_ring_desc+8, (uint8_t *)&val, 4); > >@@ -1920,6 +1921,9 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) > > descriptor, > > txdw0, txdw1, txbufLO, txbufHI)); > > > >+ /* TODO: the following discard cast should clean clang analyzer output */ > >+ (void)txdw1; > > I don't like this, why not comment it out like here: > > >+ /* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */ > > // val = cpu_to_le32(txdw1); > > // cpu_physical_memory_write(cplus_tx_ring_desc+4,&val, 4); > > (and maybe change this one as well to #if 0...#endif, I don't know). Personally I'd rather that all of this was removed until the feature is implemented.