From: Wolfgang Denk Date: Mon, 18 Jan 2010 00:02:33 +0100 Subject: [U-Boot] [PATCH v2] SPI: Fix 32 bit transfers in mxc_spi.c In-Reply-To: <1263726375-4929-1-git-send-email-lilja.magnus@gmail.com> References: <1263726375-4929-1-git-send-email-lilja.magnus@gmail.com> Message-ID: <20100117230233.23CFDC88AE@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Feng, can you please take care of this? In message <1263726375-4929-1-git-send-email-lilja.magnus@gmail.com> Magnus Lilja wrote: > Commit f9b6a1575d9f1ca192e4cb60e547aa66f08baa3f, "i.MX31: fix SPI > driver for shorter than 32 bit" broke 32 bit transfers. This patch > makes single 32 bit transfer work again. > > Transfer lengths that are known not to work will abort and print > an error message. > > Tested on i.MX31 Litekit and i.MX31 PDK using 32 bit transfers to > the MC13783/ATLAS chip (using the 'date' command). > > Signed-off-by: Magnus Lilja > --- > > As discussed on the mailing list, Guennadi Liakhovetski thinks that > all transfers > 16 bits are broken. This patch fixes the 32 bit case > and makes sure the user is notified if a broken bitlength is used. > > drivers/spi/mxc_spi.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) Acked-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A secure program has to be robust: it must be able to deal with conditions that "can't happen", whether user input, program error or library/etc. This is basic damage control. Buffer overflow errors have nothing to do with security, but everything with stupidity. -- Wietse Venema in <5cnqm3$8r9@spike.porcupine.org>