Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NaCVD-0007aE-FW for qemu-devel@nongnu.org; Wed, 27 Jan 2010 13:20:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NaCV8-0007Wh-E0 for qemu-devel@nongnu.org; Wed, 27 Jan 2010 13:20:30 -0500 Received: from [199.232.76.173] (port=35482 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaCV8-0007WU-1O for qemu-devel@nongnu.org; Wed, 27 Jan 2010 13:20:26 -0500 Received: from verein.lst.de ([213.95.11.210]:39794) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NaCV7-0000ZT-KD for qemu-devel@nongnu.org; Wed, 27 Jan 2010 13:20:25 -0500 Date: Wed, 27 Jan 2010 19:20:23 +0100 From: Christoph Hellwig Message-ID: <20100127182023.GB28893@lst.de> References: <1264594356-10375-1-git-send-email-kwolf@redhat.com> <1264594356-10375-3-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1264594356-10375-3-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] Re: [PATCH 2/3] virtio-blk: Fix restart after read error List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, hch@lst.de On Wed, Jan 27, 2010 at 01:12:35PM +0100, Kevin Wolf wrote: > Current code assumes that only write requests are ever going to be restarted. > This is wrong since rerror=stop exists. Instead of directly starting writes, > use the same request processing as used for new requests. Looks good, Reviewed-by: Christoph Hellwig