From: baruch@tkos.co.il (Baruch Siach) Date: Tue, 2 Feb 2010 09:54:02 +0200 Subject: [PATCH 3/8] imx: BUG in clk_disable if the clock isn't enabled In-Reply-To: <1265040095-31656-3-git-send-email-u.kleine-koenig@pengutronix.de> References: <20100201155625.GA22413@pengutronix.de> <1265040095-31656-3-git-send-email-u.kleine-koenig@pengutronix.de> Message-ID: <20100202075401.GA13952@jasper.tkos.co.il> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Uwe, On Mon, Feb 01, 2010 at 05:01:30PM +0100, Uwe Kleine-K?nig wrote: > Signed-off-by: Uwe Kleine-K?nig > Cc: Sascha Hauer > Cc: Russell King > --- > arch/arm/plat-mxc/clock.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-mxc/clock.c b/arch/arm/plat-mxc/clock.c > index 9e8fbd5..de99681 100644 > --- a/arch/arm/plat-mxc/clock.c > +++ b/arch/arm/plat-mxc/clock.c > @@ -56,6 +56,7 @@ static void __clk_disable(struct clk *clk) > __clk_disable(clk->parent); > __clk_disable(clk->secondary); > > + BUG_ON(!clk->usecount); > if (!(--clk->usecount) && clk->disable) > clk->disable(clk); Is this necessary? Shouldn't WARN_ON be used instead? Citing include/asm-generic/bug.h: "Don't use BUG() or BUG_ON() unless there's really no way out..." baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -