Return-path: Received: from smtp-out003.kontent.com ([81.88.40.217]:60129 "EHLO smtp-out003.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039Ab0BBO3h (ORCPT ); Tue, 2 Feb 2010 09:29:37 -0500 From: Oliver Neukum To: Roel Kluin Subject: Re: [PATCH] dvb: return -ENOMEM if kzalloc failed in dvb_usb_device_init() Date: Tue, 2 Feb 2010 15:29:36 +0100 Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, Andrew Morton , LKML References: <4B6836DA.8030907@gmail.com> In-Reply-To: <4B6836DA.8030907@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201002021529.36727.oliver@neukum.org> Sender: linux-media-owner@vger.kernel.org List-ID: Am Dienstag, 2. Februar 2010 15:29:46 schrieb Roel Kluin: > If in a cold state and the download succeeded ret is zero, but we > should return -ENOMEM. > > Signed-off-by: Roel Kluin > --- > Or shouldn't we? We should and we do if cold==0. The bug is caused by this: if (cold) { info("found a '%s' in cold state, will try to load a firmware",desc->name); ret = dvb_usb_download_firmware(udev,props); if (!props->no_reconnect || ret != 0) return ret; } which overwrites ret Regards Oliver