From: Jerome Glisse Subject: Re: [PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards. Date: Thu, 11 Feb 2010 12:51:08 +0100 Message-ID: <20100211115108.GB2181@localhost.localdomain> References: <1265839834-15808-1-git-send-email-suokkos@gmail.com> <1265839834-15808-2-git-send-email-suokkos@gmail.com> <6d4bc9fc1002101540i6f24b744vf9da81645bf34435@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <6d4bc9fc1002101540i6f24b744vf9da81645bf34435@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: Maarten Maathuis Cc: dri-devel@lists.sourceforge.net List-Id: dri-devel@lists.freedesktop.org On Thu, Feb 11, 2010 at 12:40:45AM +0100, Maarten Maathuis wrote: > What happens if you have two cards, one RS200 and one RV280 (just an > example). I think you shouldn't change values in a static struct. > Yeah good catch, it's best to do a separate asic struct for r200 rather than changing the static struct. Cheers, Jerome ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev --