Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NhSqd-00079V-SN for mharc-grub-devel@gnu.org; Tue, 16 Feb 2010 14:12:39 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhSqc-00078c-Di for grub-devel@gnu.org; Tue, 16 Feb 2010 14:12:38 -0500 Received: from [140.186.70.92] (port=43520 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhSqb-00078H-Lq for grub-devel@gnu.org; Tue, 16 Feb 2010 14:12:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NhSqZ-0006FP-5x for grub-devel@gnu.org; Tue, 16 Feb 2010 14:12:36 -0500 Received: from stallman.rootnode.net ([89.248.165.10]:39079) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NhSqY-0006FC-Uu for grub-devel@gnu.org; Tue, 16 Feb 2010 14:12:35 -0500 Received: from athlon.localnet (chello087207210055.chello.pl [87.207.210.55]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by stallman.rootnode.net (Exchange) with ESMTP id 76B6C46EFC for ; Tue, 16 Feb 2010 20:12:33 +0100 (CET) From: Szymon Janc To: grub-devel@gnu.org Date: Tue, 16 Feb 2010 20:12:56 +0100 User-Agent: KMail/1.12.4 (Linux/2.6.32-trunk-686; KDE/4.3.4; i686; ; ) References: <201002161906.07800.szymon@janc.net.pl> <4B7AE0F3.1000706@gmail.com> In-Reply-To: <4B7AE0F3.1000706@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Message-Id: <201002162012.56973.szymon@janc.net.pl> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] transparent file reader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:12:38 -0000 Dnia wtorek 16 luty 2010 o 19:16:19 Vladimir '=CF=86-coder/phcoder' Serbi= nenko=20 napisa=C5=82(a): > I like the patch however few comments: > 1) How are filters ordered? Filters are tested in order that last registered filter is tested first. = First=20 match stop further tests. > 2) How would I selectively disable a filter. E.g. for hexdump or when > payload expects compressed data? Currently one would have to unregister filters before calling grub_file_o= pen() and reregister them afterwards. However this can mix up filters order. No= t=20 a best option. I was thinking about something like: grub_file_open("name", NO_XFILTER|NO_YFILTER); grub_file_open("name",NO_ALL); to allow selectable filters or fopen() style maybe. And a priority based filter registration if there is a need for that. --=20 Szymon K. Janc szymon@janc.net.pl // GG: 1383435