From: Ernst Schwab Subject: Re: [PATCH] of: added documentation for spi chipselects Date: Wed, 17 Feb 2010 13:22:33 +0100 Message-ID: <20100217132233.19b25f4b.eschwab@online.de> References: <20100216193957.ccdffee2.eschwab@online.de> <20100216201459.GA17428@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100216201459.GA17428-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Wolfram Sang Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org Wolfram Sang wrote: > Minor: I'd prefer spaces around the '='. Done. > I'd drop the comments. GPIO controllers may have private xlate-functions, so > '1' could theoretically mean something else than "low-active" (although in > practice it hopefully won't). I dropped the polarity stuff. The "reg =" comment seems important to me, I had to find this out by grep'ing and looking at the SPI master sourcecode. Patch V2 will be reposted. Regards Ernst