From: "Rafael J. Wysocki" Subject: Re: [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs Date: Thu, 18 Feb 2010 21:01:44 +0100 Message-ID: <201002182101.44171.rjw@sisk.pl> References: <201002172335.47703.rjw@sisk.pl> <201002172341.07353.rjw@sisk.pl> <4B7CE6A3.7020103@np.css.fujitsu.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:50192 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758517Ab0BRUAr (ORCPT ); Thu, 18 Feb 2010 15:00:47 -0500 In-Reply-To: <4B7CE6A3.7020103@np.css.fujitsu.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jin Dongming Cc: Jesse Barnes , "Moore, Robert" , Len Brown , ACPI Devel Maling List , pm list , Linux PCI , Shaohua Li , Bjorn Helgaas , Oliver Neukum , Matthew Garrett , LKML , Gary Hade On Thursday 18 February 2010, Jin Dongming wrote: > Hi, Rafael J. Wysocki > > - /* Update enable mask, but don't enable the HW GPE as of yet */ > > - > > - status = acpi_ev_enable_gpe(gpe_event_info, FALSE); You could preserve some more context. > I think the above line code should be remained. If it is deleted, the exception > event will be raised on some machine. Why would it? The GPE is still disabled at the hardware level at this point. Rafael