From: Wolfgang Denk Date: Mon, 22 Feb 2010 21:54:03 +0100 Subject: [U-Boot] [PATCH 1/1] ppc4xx: add support for alternate format for ndfc In-Reply-To: <2B3B2AA816369A4E87D7BE63EC9D2F260615A5EC@SDCEXCHANGE01.ad.amcc.com> References: <1266531913-20756-1-git-send-email-fkan@amcc.com> <201002190857.18988.sr@denx.de> <4B7ED80C.5050807@amcc.com> <201002221152.25869.sr@denx.de> <2B3B2AA816369A4E87D7BE63EC9D2F260615A5EC@SDCEXCHANGE01.ad.amcc.com> Message-ID: <20100222205403.DDC5CA87D18@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Feng Kan, In message <2B3B2AA816369A4E87D7BE63EC9D2F260615A5EC@SDCEXCHANGE01.ad.amcc.com> you wrote: > > There is not a particular board that is stuck on this 213 format. Rather, for sometime u-boot > and linux both had the 213 ordering. Lets say the guy did not have the SMC define turned on, > which mean the ECC would caculate correctly for him. Now, he gets a new U-boot and want > to update it. He gets to prompt and programs the new u-boot and linux (in 213 ordering). > The new uboot comes up (it doesn't complain since there is no error message), runs to linux, > the new linux expects 123 ordering. Finds ECC error and tries to correct and crash. If this is your concern, then a compile-time setting makes little sense - you don't really expect that a user in this situation will build another U-Boot image after selecting other build options, install it (with the risk of bricking his device (keep in mind that not everybody has access to a JTAG debugger), and continue this so long until he finds a configuration that works for his combination of U-Boot and Linux settings. > I submitted this patch to support both ordering that the correction routine contains (123 and 213). But it makes no sense as a compile time option. If you want to help users, then this must be implemented in a way that is selectable at run-time, for example by simple setting an Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Everybody is talking about the weather but nobody does anything about it." - Mark Twain