Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nk033-0003i8-6f for qemu-devel@nongnu.org; Tue, 23 Feb 2010 14:03:57 -0500 Received: from [199.232.76.173] (port=56979 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nk031-0003hp-Pq for qemu-devel@nongnu.org; Tue, 23 Feb 2010 14:03:55 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nk02z-0002GX-Jb for qemu-devel@nongnu.org; Tue, 23 Feb 2010 14:03:54 -0500 Received: from hall.aurel32.net ([88.191.82.174]:46301) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nk02z-0002GS-5I for qemu-devel@nongnu.org; Tue, 23 Feb 2010 14:03:53 -0500 Date: Tue, 23 Feb 2010 20:03:50 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] target-mips: fix ROTR and DROTR by zero Message-ID: <20100223190350.GB24081@volta.aurel32.net> References: <1266690247-29046-1-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1266690247-29046-1-git-send-email-froydnj@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: qemu-devel@nongnu.org On Sat, Feb 20, 2010 at 10:24:07AM -0800, Nathan Froyd wrote: > > Signed-off-by: Nathan Froyd Thanks applied. > --- > target-mips/translate.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index dfea6f6..de5ac18 100644 > --- a/target-mips/translate.c > +++ b/target-mips/translate.c > @@ -1476,6 +1476,8 @@ static void gen_shift_imm(CPUState *env, DisasContext *ctx, uint32_t opc, > tcg_gen_rotri_i32(t1, t1, uimm); > tcg_gen_ext_i32_tl(cpu_gpr[rt], t1); > tcg_temp_free_i32(t1); > + } else { > + tcg_gen_ext32s_tl(cpu_gpr[rt], t0); > } > opn = "rotr"; > break; > @@ -1495,6 +1497,8 @@ static void gen_shift_imm(CPUState *env, DisasContext *ctx, uint32_t opc, > case OPC_DROTR: > if (uimm != 0) { > tcg_gen_rotri_tl(cpu_gpr[rt], t0, uimm); > + } else { > + tcg_gen_mov_tl(cpu_gpr[rt], t0); > } > opn = "drotr"; > break; > -- > 1.6.3.2 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net