From: Jan Kara Subject: Re: [PATCH 1/8] dquot: cleanup space allocation / freeing routines Date: Wed, 24 Feb 2010 23:09:45 +0100 Message-ID: <20100224220944.GB3097@quack.suse.cz> References: <20100220115101.469826792@bombadil.infradead.org> <20100220115212.157319450@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jack@suse.cz, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:60595 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758330Ab0BXWJh (ORCPT ); Wed, 24 Feb 2010 17:09:37 -0500 Content-Disposition: inline In-Reply-To: <20100220115212.157319450@bombadil.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat 20-02-10 06:51:02, Christoph Hellwig wrote: > Get rid of the alloc_space, free_space, reserve_space, claim_space and > release_rsv dquot operations - they are always called from the filesystem > and if a filesystem really needs their own (which none currently does) > it can just call into it's own routine directly. > > Move shared logic into the common __dquot_alloc_space, > dquot_claim_space_nodirty and __dquot_free_space low-level methods, > and rationalize the wrappers around it to move as much as possible > code into the common block for CONFIG_QUOTA vs not. Also rename > all these helpers to be named dquot_* instead of vfs_dq_*. > > Signed-off-by: Christoph Hellwig Looks fine. I've just fixed up compilation failure in case CONFIG_QUOTA was disabled and inverted numbers passed as 'warn' argument because they were historically the other way around than the name of the argument suggests. Honza -- Jan Kara SUSE Labs, CR