Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NloLd-00011O-OA for qemu-devel@nongnu.org; Sun, 28 Feb 2010 13:58:37 -0500 Received: from [199.232.76.173] (port=45924 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NloLd-00011A-Fp for qemu-devel@nongnu.org; Sun, 28 Feb 2010 13:58:37 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NloLc-00050P-0b for qemu-devel@nongnu.org; Sun, 28 Feb 2010 13:58:37 -0500 Received: from hall.aurel32.net ([88.191.82.174]:44134) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NloLb-000509-M6 for qemu-devel@nongnu.org; Sun, 28 Feb 2010 13:58:35 -0500 Date: Sun, 28 Feb 2010 19:58:29 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] * Fixed problem with IT AL. Message-ID: <20100228185829.GS10291@volta.aurel32.net> References: <1265730227-21926-1-git-send-email-teofrastius@gmail.com> <1265730227-21926-2-git-send-email-teofrastius@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1265730227-21926-2-git-send-email-teofrastius@gmail.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Johan Bengtsson Cc: qemu-devel@nongnu.org The patch looks ok. Can you please resend it with a Signed-of-by: line, and maybe a better subject mentioning ARM? On Tue, Feb 09, 2010 at 04:43:47PM +0100, Johan Bengtsson wrote: > --- > target-arm/translate.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/target-arm/translate.c b/target-arm/translate.c > index 786c329..554583d 100644 > --- a/target-arm/translate.c > +++ b/target-arm/translate.c > @@ -8328,9 +8328,11 @@ static void disas_thumb_insn(CPUState *env, DisasContext *s) > > if (s->condexec_mask) { > cond = s->condexec_cond; > - s->condlabel = gen_new_label(); > - gen_test_cc(cond ^ 1, s->condlabel); > - s->condjmp = 1; > + if (cond != 0x0e) { /* Skip conditional when condition is AL. */ > + s->condlabel = gen_new_label(); > + gen_test_cc(cond ^ 1, s->condlabel); > + s->condjmp = 1; > + } > } > > insn = lduw_code(s->pc); > -- > 1.6.3.3 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net