From: Mark Brown Subject: Re: [PATCH 17/20] ASoC: S3C: I2Sv2: Define new field for controller features Date: Wed, 10 Mar 2010 11:11:49 +0000 Message-ID: <20100310111148.GA2001@sirena.org.uk> References: <1268207349-9979-9-git-send-email-jassi.brar@samsung.com> <1268207349-9979-10-git-send-email-jassi.brar@samsung.com> <1268207349-9979-11-git-send-email-jassi.brar@samsung.com> <1268207349-9979-12-git-send-email-jassi.brar@samsung.com> <1268207349-9979-13-git-send-email-jassi.brar@samsung.com> <1268207349-9979-14-git-send-email-jassi.brar@samsung.com> <1268207349-9979-15-git-send-email-jassi.brar@samsung.com> <1268207349-9979-16-git-send-email-jassi.brar@samsung.com> <1268207349-9979-17-git-send-email-jassi.brar@samsung.com> <20100310110958.GI24422@rakim.wolfsonmicro.main> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id 141AF243D1 for ; Wed, 10 Mar 2010 12:11:51 +0100 (CET) Content-Disposition: inline In-Reply-To: <20100310110958.GI24422@rakim.wolfsonmicro.main> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Jassi Brar Cc: alsa-devel@alsa-project.org, ben-linux@fluff.org List-Id: alsa-devel@alsa-project.org On Wed, Mar 10, 2010 at 11:09:59AM +0000, Mark Brown wrote: > Probably worth namespacing these defines a bit more (eg, S3C_IIS_) since > I'd expect they'll end up being used by the arch/arm code too in the > platform data definition. They ought to be in include/sound or arch/arm > for visibility to arch/arm code too. Meh, scratch that - I see where this is being used now.