From: Tim Deegan Subject: Re: [PATCH][v7] PV extension of HVM(hybrid) support in Xen Date: Thu, 11 Mar 2010 12:02:09 +0000 Message-ID: <20100311120209.GC4334@whitby.uk.xensource.com> References: <201003081521.39829.sheng@linux.intel.com> <20100310144446.GA4334@whitby.uk.xensource.com> <201003111011.46605.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Return-path: Content-Disposition: inline In-Reply-To: <201003111011.46605.sheng@linux.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Sheng Yang Cc: xen-devel , Stefano Stabellini , Campbell , Ian Pratt Ian, Keir Fraser List-Id: xen-devel@lists.xenproject.org At 02:11 +0000 on 11 Mar (1268273506), Sheng Yang wrote: > > Shouldn't this be gated on (d->hvm_pv_enabled & XEN_HVM_PV_CLOCK_ENABLED) > > rather than (eip != 0)? > > Um... I think no other HVM should call this, and evtchn shouldn't work > without PV clocksource... And it have two meaning here: one is setting > up the start up IP for AP, another is initial PV clock. I would > update this to get it more clear. Yes, I was just talking about the last line, where you set the offset to zero. Since you have introduced a flag that says whether the clocksource is enabled, you should use it. > > Maybe use cpuid_edx() here? > > Um? It's not native cpuid, but the one configuration file specific. Yes, you're quite right. I misread the code. Thanks, Tim. -- Tim Deegan Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)