Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NpzlR-0005A5-PD for qemu-devel@nongnu.org; Fri, 12 Mar 2010 02:58:33 -0500 Received: from [199.232.76.173] (port=50881 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NpzlR-00059w-8P for qemu-devel@nongnu.org; Fri, 12 Mar 2010 02:58:33 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NpzlP-0000zg-OP for qemu-devel@nongnu.org; Fri, 12 Mar 2010 02:58:32 -0500 Received: from hall.aurel32.net ([88.191.82.174]:38633) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NpzlP-0000zM-Fm for qemu-devel@nongnu.org; Fri, 12 Mar 2010 02:58:31 -0500 Date: Fri, 12 Mar 2010 08:58:27 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers Message-ID: <20100312075827.GJ17041@hall.aurel32.net> References: <4B98FA68.7000901@codemonkey.ws> <1268318923-13397-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1268318923-13397-1-git-send-email-avi@redhat.com> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org On Thu, Mar 11, 2010 at 04:48:43PM +0200, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > CODING_STYLE | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index a579cb1..92036f3 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -49,6 +49,9 @@ and is therefore likely to be changed. > Typedefs are used to eliminate the redundant 'struct' keyword. It is the > QEMU coding style. > > +When wrapping standard library functions, use the prefix qemu_ to alert > +readers that they are seeing a wrapped version; otherwise avoid this prefix. > + > 4. Block structure > > Every indented statement is braced; even if the block contains just one Acked-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net