Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nq5QU-0006gD-5D for qemu-devel@nongnu.org; Fri, 12 Mar 2010 09:01:18 -0500 Received: from [199.232.76.173] (port=33879 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nq5QT-0006fe-JQ for qemu-devel@nongnu.org; Fri, 12 Mar 2010 09:01:17 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nq5QR-0002RT-Uo for qemu-devel@nongnu.org; Fri, 12 Mar 2010 09:01:17 -0500 Received: from verein.lst.de ([213.95.11.210]:42328) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1Nq5QR-0002Cj-8Y for qemu-devel@nongnu.org; Fri, 12 Mar 2010 09:01:15 -0500 Date: Fri, 12 Mar 2010 15:01:11 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] raw-posix: Better error return values for hdev_create Message-ID: <20100312140111.GA20429@lst.de> References: <1268398351-8113-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1268398351-8113-1-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Fri, Mar 12, 2010 at 01:52:31PM +0100, Kevin Wolf wrote: > Now that we output an error message according to the returned error code in > qemu-img, let's return the real error codes. "Input/output error" for > everything isn't helpful. > > Signed-off-by: Kevin Wolf Looks good, Reviewed-by: Christoph Hellwig