Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NriWt-0003ma-1Q for qemu-devel@nongnu.org; Tue, 16 Mar 2010 21:58:39 -0400 Received: from [199.232.76.173] (port=46884 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NriWs-0003m2-Ll for qemu-devel@nongnu.org; Tue, 16 Mar 2010 21:58:38 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NriWr-0003xh-6V for qemu-devel@nongnu.org; Tue, 16 Mar 2010 21:58:38 -0400 Received: from b.painless.aaisp.net.uk ([81.187.30.52]:48989) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NriWq-0003xd-Ty for qemu-devel@nongnu.org; Tue, 16 Mar 2010 21:58:37 -0400 Received: from zubnet.me.uk ([81.187.243.246] helo=circe) by b.painless.aaisp.net.uk with esmtp (Exim 4.69) (envelope-from ) id 1NriWo-0007Gu-Rf for qemu-devel@nongnu.org; Wed, 17 Mar 2010 01:58:34 +0000 Date: Wed, 17 Mar 2010 01:58:29 +0000 From: Stuart Brady Subject: Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port. Message-ID: <20100317015829.GC23195@zubnet.me.uk> References: <6880f84577b97d0334b95f6ce031e61c65c2e88b.1268754659.git.rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6880f84577b97d0334b95f6ce031e61c65c2e88b.1268754659.git.rth@twiddle.net> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sat, Feb 20, 2010 at 11:46:06AM -0800, Richard Henderson wrote: > Delete inline functions from tcg-target.h that don't need to be there, > move the others to tcg-target.c. Add 'Z', 'I', 'J' constraints for > 0, signed 11-bit, and signed 5-bit respectively. Add 'c' constraint > for RET1 register. Add GUEST_BASE support similar to ppc64, with the > value stored in a register. Add missing registers to reg_alloc_order. > Add support for 12-bit branch relocations. Add functions for synthetic > operations: addi, mtctl, dep, shd, vshd, ori, andi, shifts, rotates, > multiply, millicode calls, branches, setcond. Split out TLB reads from > qemu_ld and qemu_st; fix argument loading for tlb external calls. > Generate the prologue. > > Signed-off-by: Richard Henderson Acked-by: Stuart Brady I suppose you'd normally have split this into smaller patches, which would make reviewing easier, but there's hardly any risk of regressions, here. I'm away from my HPPA box for a few weeks, so can't really test, but I can't see anything obviously wrong. I'll try to read through this a little more thoroughly at a later date, but this patch certainly can't make matters any worse than they are... (Bearing in mind that the half-finished HPPA support was written fairly soon after the move to TCG and wasn't substantially updated since!) The tcg_reg_free() calls worry me slightly, but I assume they're safe... -- Stuart Brady