From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: >2 serial ports?
Date: Wed, 17 Mar 2010 11:18:09 +0000
Message-ID: <201003171118.09873.paul@codesourcery.com>
References: <4BA094FE.6020109@msgid.tls.msk.ru> <4BA09E41.7000300@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	Michael Tokarev <mjt@tls.msk.ru>,
	KVM list <kvm@vger.kernel.org>
To: qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail.codesourcery.com ([38.113.113.100]:43742 "EHLO
	mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754329Ab0CQLSa (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 17 Mar 2010 07:18:30 -0400
In-Reply-To: <4BA09E41.7000300@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

> Oh, well, yes, I remember.  qemu is more strict on ISA irq sharing now.
>   A bit too strict.
> 
> /me goes dig out a old patch which never made it upstream for some
> reason I forgot.  Attached.

This is wrong. Two devices should never be manipulating the same qemu_irq 
object.  If you want multiple devices connected to the same IRQ then you need 
an explicit multiplexer. e.g. arm_timer.c:sp804_set_irq.

Paul