Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NrzRO-0003GS-DF for qemu-devel@nongnu.org; Wed, 17 Mar 2010 16:02:06 -0400 Received: from [199.232.76.173] (port=34101 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NrzRN-0003G2-TY for qemu-devel@nongnu.org; Wed, 17 Mar 2010 16:02:05 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NrzRK-0005A6-NE for qemu-devel@nongnu.org; Wed, 17 Mar 2010 16:02:05 -0400 Received: from b.painless.aaisp.net.uk ([81.187.30.52]:57385) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NrzRK-00059w-Ef for qemu-devel@nongnu.org; Wed, 17 Mar 2010 16:02:02 -0400 Date: Wed, 17 Mar 2010 20:01:54 +0000 From: Stuart Brady Subject: Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port. Message-ID: <20100317200154.GA4439@zubnet.me.uk> References: <6880f84577b97d0334b95f6ce031e61c65c2e88b.1268754659.git.rth@twiddle.net> <20100317015829.GC23195@zubnet.me.uk> <4BA0ED8C.8000404@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BA0ED8C.8000404@twiddle.net> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org On Wed, Mar 17, 2010 at 07:56:12AM -0700, Richard Henderson wrote: > On 03/16/2010 06:58 PM, Stuart Brady wrote: > > The tcg_reg_free() calls worry me slightly, but I assume they're safe... > > Yeah, that one's rather gross. > > Since Aurelien's generic div/rem patch I could simply remove all > that millicode stuff, including that tcg_reg_free, and let the > generic code handle this instead. Which would get to the same > millicode routine via one or two extra levels of indirection. > > Thoughts? Well, assuming that the millicode stuff does indeed work, I wouldn't worry too much about it... I only imagine that this is something that other archs might need to do too, so it'd be worth doing as cleanly as possible. Likewise, the qemu_ld/qemu_st refactoring should really be done for other archs at some later stage, too, as it's quite a significant improvement in readability of the code. Cheers, -- Stuart Brady