From: David Gibson Subject: Re: [v2 PATCH] of/flattree: Fix unhandled OF_DT_NOP tag when unflattening the device tree Date: Sat, 20 Mar 2010 11:24:07 +1100 Message-ID: <20100320002407.GA15222@yookeroo> References: <20100319200049.5195.97171.stgit@angua> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20100319200049.5195.97171.stgit@angua> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Mar 19, 2010 at 02:01:49PM -0600, Grant Likely wrote: > From: Jason Gunthorpe > > NOPs within the property section are skipped, but NOPs between > OF_DT_END_NODE and OF_DT_BEGIN_NODE were not. My firmware NOPs out > entire nodes depending on various environment parameters. > > of_scan_flat_dt already handles NOP more generally. Fwiw, there's a test program in the libfdt/dtc tree called "nopulate" which will liberally spread NOPs through a device tree blob (one between every other tag), which might be useful for testing this -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson