From: Mike Frysinger Date: Thu, 25 Mar 2010 13:38:17 -0400 Subject: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom In-Reply-To: <20100325094002.00014E731ED@gemini.denx.de> References: <4BA9FDEC.9010903@denx.de> <4BAB0357.60309@denx.de> <20100325094002.00014E731ED@gemini.denx.de> Message-ID: <201003251338.18817.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 25 March 2010 05:40:01 Wolfgang Denk wrote: > Heiko wrote: > > Ok, but this driver initialize in fec_probe() (which gets called > > through fecmxc_initialize() on uboot startup) always the fec mac > > address registers with eeprom mac address. So, if uboot not uses > > The question to me is why fec_probe() is called at all, even in cases > where U-Boot does not use any network related commands. This is IMO > wrong. Eventually somebody comes up with patches to fix this? the current fec_mxc driver has squashed the initialize and probe steps. it should have half the things removed from probe and put into initialize and then the call to probe moved to the init step. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100325/eafcb2b9/attachment.pgp