Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvHoG-00071M-6g for qemu-devel@nongnu.org; Fri, 26 Mar 2010 18:15:20 -0400 Received: from [140.186.70.92] (port=57085 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvHoC-0006zt-3C for qemu-devel@nongnu.org; Fri, 26 Mar 2010 18:15:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NvHo8-0007z3-KH for qemu-devel@nongnu.org; Fri, 26 Mar 2010 18:15:16 -0400 Received: from hall.aurel32.net ([88.191.82.174]:34780) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvHo8-0007yo-CY for qemu-devel@nongnu.org; Fri, 26 Mar 2010 18:15:12 -0400 Date: Fri, 26 Mar 2010 23:15:09 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 1/4] linux-user: add pselect syscall Message-ID: <20100326221509.GE15194@volta.aurel32.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Riku Voipio Cc: Michael Casadevall , Riku Voipio , qemu-devel@nongnu.org On Fri, Mar 26, 2010 at 03:25:09PM +0000, Riku Voipio wrote: > From: Michael Casadevall > > This patch adds support for the pselect syscall in linux-user emulation > and also adds several support functions required to translate the > timespec structs between the target and the host. > > Signed-off-by: Riku Voipio > Signed-off-by: Michael Casadevall > --- > linux-user/syscall.c | 119 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 119 insertions(+), 0 deletions(-) This patch basically needs ok, but need to conform to CODING_STYLE (see below). > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 80d8633..845bb60 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -850,6 +850,38 @@ static inline abi_long copy_to_user_timeval(abi_ulong target_tv_addr, > return 0; > } > > +static inline abi_long copy_from_user_timespec(struct timespec *ts, > + abi_ulong target_ts_addr) > +{ > + struct target_timespec *target_ts; > + > + if (!lock_user_struct(VERIFY_READ, target_ts, target_ts_addr, 1)) > + return -TARGET_EFAULT; You should use curly braces around the return; > + > + __get_user(ts->tv_sec, &target_ts->tv_sec); > + __get_user(ts->tv_nsec, &target_ts->tv_nsec); > + > + unlock_user_struct(target_ts, target_ts_addr, 0); > + > + return 0; > +} > + > + > +static inline abi_long copy_to_user_timespec(abi_ulong target_ts_addr, > + const struct timespec *ts) > +{ > + struct target_timespec *target_ts; > + > + if (!lock_user_struct(VERIFY_WRITE, target_ts, target_ts_addr, 0)) > + return -TARGET_EFAULT; > + > + __put_user(ts->tv_sec, &target_ts->tv_sec); > + __put_user(ts->tv_nsec, &target_ts->tv_nsec); > + > + unlock_user_struct(target_ts, target_ts_addr, 1); > + > + return 0; > +} > #if defined(TARGET_NR_mq_open) && defined(__NR_mq_open) > #include > > @@ -949,6 +981,75 @@ static abi_long do_select(int n, > return ret; > } > > +#ifdef TARGET_NR_pselect6 > +/* do_pselect() must return target values and target errnos. */ > +static abi_long do_pselect(int n, > + abi_ulong rfd_addr, abi_ulong wfd_addr, > + abi_ulong efd_addr, abi_ulong target_tv_addr, > + abi_ulong set_addr) > +{ > + fd_set rfds, wfds, efds; > + fd_set *rfds_ptr, *wfds_ptr, *efds_ptr; > + struct timespec tv, *tv_ptr; > + sigset_t set, *set_ptr; > + abi_long ret; > + > + if (rfd_addr) { > + if (copy_from_user_fdset(&rfds, rfd_addr, n)) > + return -TARGET_EFAULT; Same here, and later on. > + rfds_ptr = &rfds; > + } else { > + rfds_ptr = NULL; > + } > + if (wfd_addr) { > + if (copy_from_user_fdset(&wfds, wfd_addr, n)) > + return -TARGET_EFAULT; > + wfds_ptr = &wfds; > + } else { > + wfds_ptr = NULL; > + } > + if (efd_addr) { > + if (copy_from_user_fdset(&efds, efd_addr, n)) > + return -TARGET_EFAULT; > + efds_ptr = &efds; > + } else { > + efds_ptr = NULL; > + } > + > + if (target_tv_addr) { > + if (copy_from_user_timespec(&tv, target_tv_addr)) > + return -TARGET_EFAULT; > + tv_ptr = &tv; > + } else { > + tv_ptr = NULL; > + } > + > + /* We don't need to return sigmask to target */ > + if (set_addr) { > + target_to_host_old_sigset(&set, &set_addr); > + set_ptr = &set; > + } else { > + set_ptr = NULL; > + } > + > + ret = get_errno(pselect(n, rfds_ptr, wfds_ptr, efds_ptr, tv_ptr, set_ptr)); > + > + if (!is_error(ret)) { > + if (rfd_addr && copy_to_user_fdset(rfd_addr, &rfds, n)) > + return -TARGET_EFAULT; > + if (wfd_addr && copy_to_user_fdset(wfd_addr, &wfds, n)) > + return -TARGET_EFAULT; > + if (efd_addr && copy_to_user_fdset(efd_addr, &efds, n)) > + return -TARGET_EFAULT; > + > + if (target_tv_addr && copy_to_user_timespec(target_tv_addr, &tv)) > + return -TARGET_EFAULT; > + } > + > + return ret; > +} > +#endif > + > static abi_long do_pipe2(int host_pipe[], int flags) > { > #ifdef CONFIG_PIPE2 > @@ -5186,6 +5287,24 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, > } > break; > #endif > + > +#ifdef TARGET_NR_pselect6 > + case TARGET_NR_pselect6: > + { > + abi_ulong inp, outp, exp, tvp, set; > + long nsel; > + > + nsel = tswapl(arg1); > + inp = tswapl(arg2); > + outp = tswapl(arg3); > + exp = tswapl(arg4); > + tvp = tswapl(arg5); > + set = tswapl(arg6); > + > + ret = do_pselect(nsel, inp, outp, exp, tvp, set); > + } > + break; > +#endif > case TARGET_NR_symlink: > { > void *p2; > -- > 1.6.5 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net