Return-Path: Received: from ksp.mff.cuni.cz ([195.113.26.206]:38294 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751513Ab0C0GPG (ORCPT ); Sat, 27 Mar 2010 02:15:06 -0400 Date: Sat, 27 Mar 2010 07:14:30 +0100 From: Pavel Machek Subject: Re: [PATCH 1/7] arm: msm: smd: checkpatch clean up of smd/proc_comm Message-ID: <20100327061430.GG18689@elf.ucw.cz> References: <> <1269647725-4577-1-git-send-email-dwalker@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1269647725-4577-1-git-send-email-dwalker@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Daniel Walker Cc: linux-arm-msm@vger.kernel.org On Fri 2010-03-26 16:55:19, Daniel Walker wrote: > This cleans up codeing style. There are no run time changes. > > Signed-off-by: Daniel Walker ACK. > @@ -904,9 +902,9 @@ static irqreturn_t smsm_irq_handler(int irq, void *data) > > if (msm_smd_debug_mask & MSM_SMSM_DEBUG) > pr_info("\n", apps, modm); > - if (modm & SMSM_RESET) { > + if (modm & SMSM_RESET) > handle_modem_crash(); > - } > + > do_smd_probe(); > > spin_unlock_irqrestore(&smem_lock, flags); Even through I do not think this is an improvement. Especially considering the if() immediately before that. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html