Return-Path: Received: from ksp.mff.cuni.cz ([195.113.26.206]:36651 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751759Ab0C0GUK (ORCPT ); Sat, 27 Mar 2010 02:20:10 -0400 Date: Sat, 27 Mar 2010 07:19:56 +0100 From: Pavel Machek Subject: Re: [PATCH 4/7] arm: msm: smd: msm7x30 a2m clean up Message-ID: <20100327061956.GI18689@elf.ucw.cz> References: <> <1269647725-4577-4-git-send-email-dwalker@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1269647725-4577-4-git-send-email-dwalker@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Daniel Walker Cc: linux-arm-msm@vger.kernel.org On Fri 2010-03-26 16:55:22, Daniel Walker wrote: > This moves the msm_a2m_int() function into the header, and > does a small macro clean up to be more inline with Linux > norms. No functional changes. > > Signed-off-by: Daniel Walker ACK. > --- > arch/arm/mach-msm/smd.c | 12 ------------ > arch/arm/mach-msm/smd_private.h | 16 ++++++++++++++++ > 2 files changed, 16 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c > index 2e32d9a..2a9b85c 100644 > --- a/arch/arm/mach-msm/smd.c > +++ b/arch/arm/mach-msm/smd.c > @@ -26,10 +26,8 @@ > #include > #include > #include > -#include > > #include > -#include > #include > > #include "smd_private.h" > @@ -69,16 +67,6 @@ static void smd_diag(void); > > static unsigned last_heap_free = 0xffffffff; > > -static inline void msm_a2m_int(uint32_t irq) > -{ > -#if defined(CONFIG_ARCH_MSM7X30) > - writel(1 << irq, MSM_GCC_BASE + 0x8); > -#else > - writel(1, MSM_CSR_BASE + 0x400 + (irq * 4)); > -#endif > -} > - > - > static inline void notify_other_smsm(void) > { > msm_a2m_int(5); > diff --git a/arch/arm/mach-msm/smd_private.h b/arch/arm/mach-msm/smd_private.h > index a403424..54a6007 100644 > --- a/arch/arm/mach-msm/smd_private.h > +++ b/arch/arm/mach-msm/smd_private.h > @@ -19,6 +19,9 @@ > #include > #include > #include > +#include > + > +#include > > struct smem_heap_info { > unsigned initialized; > @@ -384,4 +387,17 @@ static inline int _smd_alloc_channel(struct smd_channel *ch) > } > #endif /* CONFIG_ARCH_MSM7X00A */ > > +#if defined(CONFIG_ARCH_MSM7X30) > +static inline void msm_a2m_int(uint32_t irq) > +{ > + writel(1 << irq, MSM_GCC_BASE + 0x8); > +} > +#else > +static inline void msm_a2m_int(uint32_t irq) > +{ > + writel(1, MSM_CSR_BASE + 0x400 + (irq * 4)); > +} > +#endif /* CONFIG_ARCH_MSM7X30 */ > + > + > #endif -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html