Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvVDD-0002zz-9y for qemu-devel@nongnu.org; Sat, 27 Mar 2010 08:33:59 -0400 Received: from [140.186.70.92] (port=48142 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvVDB-0002yR-Ly for qemu-devel@nongnu.org; Sat, 27 Mar 2010 08:33:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NvVDA-0001Z2-39 for qemu-devel@nongnu.org; Sat, 27 Mar 2010 08:33:57 -0400 Received: from hall.aurel32.net ([88.191.82.174]:49018) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvVD9-0001Yx-UT for qemu-devel@nongnu.org; Sat, 27 Mar 2010 08:33:56 -0400 Date: Sat, 27 Mar 2010 13:33:54 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] qemu-io: fix aio help texts Message-ID: <20100327123354.GA19681@volta.aurel32.net> References: <20100316181258.GA10555@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100316181258.GA10555@lst.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org On Tue, Mar 16, 2010 at 07:12:58PM +0100, Christoph Hellwig wrote: > Fix a few typos in the helptexts for the various aio commands. This is clearly an improvement, but it introduces a typo (see below). > Signed-off-by: Christoph Hellwig > > Index: qemu/qemu-io.c > =================================================================== > --- qemu.orig/qemu-io.c 2010-03-16 19:07:43.089009269 +0100 > +++ qemu/qemu-io.c 2010-03-16 19:08:36.597005148 +0100 > @@ -904,8 +904,8 @@ aio_read_help(void) > "\n" > " Reads a segment of the currently open file, optionally dumping it to the\n" > " standard output stream (with -v option) for subsequent inspection.\n" > -" The read is performed asynchronously and should the aio_flush command \n" > -" should be used to ensure all outstanding aio requests have been completed\n" > +" The read is performed asynchronously and the aio_flush command must be\n" "used" is missing here. > +" to ensure all outstanding aio requests have been completed\n" > " -C, -- report statistics in a machine parsable format\n" > " -P, -- use a pattern to verify read data\n" > " -v, -- dump buffer to standard output\n" > @@ -1003,8 +1003,8 @@ aio_write_help(void) > "\n" > " Writes into a segment of the currently open file, using a buffer\n" > " filled with a set pattern (0xcdcdcdcd).\n" > -" The write is performed asynchronously and should the aio_flush command \n" > -" should be used to ensure all outstanding aio requests have been completed\n" > +" The write is performed asynchronously and the aio_flush command must be\n" > +" used to ensure all outstanding aio requests have been completed\n" > " -P, -- use different pattern to fill file\n" > " -C, -- report statistics in a machine parsable format\n" > " -q, -- quite mode, do not show I/O statistics\n" > @@ -1095,7 +1095,7 @@ aio_flush_f(int argc, char **argv) > static const cmdinfo_t aio_flush_cmd = { > .name = "aio_flush", > .cfunc = aio_flush_f, > - .oneline = "completes all outstanding aio requets" > + .oneline = "completes all outstanding aio requests" > }; > > static int > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net