Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvsHo-0005EE-1G for qemu-devel@nongnu.org; Sun, 28 Mar 2010 09:12:16 -0400 Received: from [140.186.70.92] (port=35804 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvsHm-0005CK-3q for qemu-devel@nongnu.org; Sun, 28 Mar 2010 09:12:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NvsHk-00007f-VP for qemu-devel@nongnu.org; Sun, 28 Mar 2010 09:12:14 -0400 Received: from verein.lst.de ([213.95.11.210]:52539) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvsHk-00007b-Mm for qemu-devel@nongnu.org; Sun, 28 Mar 2010 09:12:12 -0400 Date: Sun, 28 Mar 2010 15:12:10 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [RFC][PATCH 6/7] blkdebug: Add events and rules Message-ID: <20100328131210.GA13453@lst.de> References: <1268672915-12233-1-git-send-email-kwolf@redhat.com> <1268672915-12233-7-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1268672915-12233-7-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Mon, Mar 15, 2010 at 06:08:34PM +0100, Kevin Wolf wrote: > + fprintf(stderr, "bdrv_debug_event: %d\n", event); Is this supposed to be in the final version or a leftover debugging aid? > +#define BLKDBG_EVENT(bs, evt) bdrv_debug_event(bs, evt) Why not call bdrv_debug_event directly? > + config = strdup(filename); > + config[c - filename] = '\0'; > + ret = read_config(s, config); > + if (ret < 0) { > + return ret; > + } > + filename = c + 1; > + > + /* Open the backing file */ > + ret = bdrv_file_open(&s->hd, filename, flags); > + if (ret < 0) { > + return ret; > + } > + > + return 0; Don't we need to free config somewhere?