Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwHmX-0003QO-G2 for qemu-devel@nongnu.org; Mon, 29 Mar 2010 12:25:41 -0400 Received: from [140.186.70.92] (port=53839 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwHmV-0003Nr-VI for qemu-devel@nongnu.org; Mon, 29 Mar 2010 12:25:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwHmT-0006u2-Hi for qemu-devel@nongnu.org; Mon, 29 Mar 2010 12:25:39 -0400 Received: from hall.aurel32.net ([88.191.82.174]:46488) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NwHmT-0006rp-Ck for qemu-devel@nongnu.org; Mon, 29 Mar 2010 12:25:37 -0400 Date: Mon, 29 Mar 2010 18:25:27 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] Re: [PATCH 1/5] linux-user/ia64: workaround ia64 strangenesses Message-ID: <20100329162527.GD13677@hall.aurel32.net> References: <1269822354-4878-1-git-send-email-aurelien@aurel32.net> <1269822354-4878-2-git-send-email-aurelien@aurel32.net> <4BB074B2.4090209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <4BB074B2.4090209@redhat.com> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Mon, Mar 29, 2010 at 11:36:50AM +0200, Paolo Bonzini wrote: > >> +#ifdef __ia64 >> + sigprocmask(SIG_SETMASK, (sigset_t *)&uc->uc_sigmask, NULL); >> +#else >> sigprocmask(SIG_SETMASK,&uc->uc_sigmask, NULL); >> +#endif > > Any reason for the ifdef? > It is not strictly needed, as all architectures can cope with the ia64 version. I have added it to make sure that a new architecture triggers a warning if uc->uc_sigmask is not of type sigset_t, so that a human can verify the cast is correct. That said, I am fine removing the #ifdef if we consider this is unlikely to happen. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net