Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwTct-0000Zb-Ky for qemu-devel@nongnu.org; Tue, 30 Mar 2010 01:04:31 -0400 Received: from [140.186.70.92] (port=44619 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwTcr-0000YO-OG for qemu-devel@nongnu.org; Tue, 30 Mar 2010 01:04:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwTcq-0003yf-AZ for qemu-devel@nongnu.org; Tue, 30 Mar 2010 01:04:29 -0400 Received: from hall.aurel32.net ([88.191.82.174]:58332) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NwTcq-0003yO-1M for qemu-devel@nongnu.org; Tue, 30 Mar 2010 01:04:28 -0400 Date: Tue, 30 Mar 2010 07:04:25 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] Re: [PATCH 1/5] linux-user/ia64: workaround ia64 strangenesses Message-ID: <20100330050425.GA16645@hall.aurel32.net> References: <1269822354-4878-1-git-send-email-aurelien@aurel32.net> <1269822354-4878-2-git-send-email-aurelien@aurel32.net> <4BB074B2.4090209@redhat.com> <20100329162527.GD13677@hall.aurel32.net> <20100330000039.GH9876@shareable.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100330000039.GH9876@shareable.org> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jamie Lokier Cc: Paolo Bonzini , qemu-devel@nongnu.org On Tue, Mar 30, 2010 at 01:00:39AM +0100, Jamie Lokier wrote: > Aurelien Jarno wrote: > > On Mon, Mar 29, 2010 at 11:36:50AM +0200, Paolo Bonzini wrote: > > > > > >> +#ifdef __ia64 > > >> + sigprocmask(SIG_SETMASK, (sigset_t *)&uc->uc_sigmask, NULL); > > >> +#else > > >> sigprocmask(SIG_SETMASK,&uc->uc_sigmask, NULL); > > >> +#endif > > > > > > Any reason for the ifdef? > > > > > > > It is not strictly needed, as all architectures can cope with the ia64 > > version. I have added it to make sure that a new architecture triggers a > > warning if uc->uc_sigmask is not of type sigset_t, so that a human can > > verify the cast is correct. > > What type is the ia64 uc_sigmask, if not sigset_t? It is defined as a unsigned long int. From : | /* sc_mask is actually an sigset_t but we don't want to | * include the kernel headers here. */ | unsigned long int sc_mask; /* signal mask to restore after handler returns */ -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net