Message-ID: <20100331230347.1687.qmail@...1287...> Date: Thu, 1 Apr 2010 01:03:46 +0200 From: Peter Stuge References: <70dd1e1441bb32df36f449920384f20a3683a2f0.1270060247.git.fabian.knittel@...1338...> MIME-Version: 1.0 In-Reply-To: <70dd1e1441bb32df36f449920384f20a3683a2f0.1270060247.git.fabian.knittel@...1338...> Subject: Re: [Openvpn-devel] [PATCH 3/9] vlan: Add per-client --vlan-tag option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline To: openvpn-devel@lists.sourceforge.net Fabian Knittel wrote: > + if (options->vlan_tag < OPENVPN_8021Q_MIN_VID || options->vlan_tag > OPENVPN_8021Q_MAX_VID) .. > +#define OPENVPN_8021Q_MIN_VID 1 This looks like --vlan-tag 0 will not work. > +#define OPENVPN_8021Q_MAX_VID 0xFFFE The max VID in 802.1q is 4095 = 0xfff. //Peter