From: Mike Frysinger Date: Fri, 2 Apr 2010 14:22:06 -0400 Subject: [U-Boot] [PATCH 1/3] The BUILD_BUG_ON macros moved from ubi_uboot.h to common.h In-Reply-To: References: <1270142213-24765-1-git-send-email-michael.zaidman@gmail.com> <201004020452.48368.vapier@gentoo.org> Message-ID: <201004021422.08362.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 02 April 2010 06:56:41 Michael Zaidman wrote: > On Fri, Apr 2, 2010 at 11:52 AM, Mike Frysinger wrote: > > On Thursday 01 April 2010 13:16:53 Michael Zaidman wrote: > >> The BUILD_BUG_ON macros made availible for rest of the u-boot code > >> by moving it from ubi_uboot.h to common.h. In Linux kernel this > >> widely used macros is defined in kernel.h file. > > > > compiler.h might be a better place so that it is available to host tools > > too > > The common.h includes image.h which includes compiler.h, so > technically it should works also. you're looking the wrong direction. host tools include compiler.h, they dont include common.h. > I have a doubt however - what about location of similar staff such as BUG, > BUG_ON, debug, error, etc. Should it also be moved into compiler.h file? many should not. BUG_ON requires functions that only u-boot implements and are not available in host C libraries. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100402/ee8ba090/attachment.pgp