From: Mike Frysinger Date: Sat, 3 Apr 2010 08:47:08 -0400 Subject: [U-Boot] [PATCH 1/3] The BUILD_BUG_ON macros moved from ubi_uboot.h to common.h In-Reply-To: References: <1270142213-24765-1-git-send-email-michael.zaidman@gmail.com> <201004021422.08362.vapier@gentoo.org> Message-ID: <201004030847.10754.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 03 April 2010 04:23:58 Michael Zaidman wrote: > On Fri, Apr 2, 2010 at 9:22 PM, Mike Frysinger wrote: > >> I have a doubt however - what about location of similar staff such as > >> BUG, BUG_ON, debug, error, etc. Should it also be moved into compiler.h > >> file? > > > > many should not. BUG_ON requires functions that only u-boot implements > > and are not available in host C libraries. > > So why do not place all useful staff which pass the compilation into > compiler.h file? i just told you why: only things that work with general C libraries/compilers may go into compiler.h. BUG_ON does not fall into that category. BUILD_BUG_ON does. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100403/c221c192/attachment.pgp