From: Rabin VINCENT Date: Thu, 8 Apr 2010 19:11:36 +0530 Subject: [U-Boot] [PATCH 8/8] mop500: add board-specific files In-Reply-To: <4BAF969B.1030608@windriver.com> References: <1268886061-6382-1-git-send-email-rabin.vincent@stericsson.com> <1268890402-31618-1-git-send-email-rabin.vincent@stericsson.com> <4BAF969B.1030608@windriver.com> Message-ID: <20100408134135.GA4828@bnru02.bnr.st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Mar 28, 2010 at 07:49:15PM +0200, Tom wrote: > Rabin Vincent wrote: > > + /* UART2 */ > > + nmk_gpio_af(29, GPIO_ALT_C); > > + nmk_gpio_af(30, GPIO_ALT_C); > > Change these to immediates to logical #define's I've changed this in the other places you mentioned, but for these GPIOs, I'd prefer to use the pin numbers directly. Rabin