From: Wolfgang Denk <wd@denx.de>
Date: Sat, 10 Apr 2010 00:28:14 +0200
Subject: [U-Boot] [PATCH 8/8] mop500: add board-specific files
In-Reply-To: <20100408134135.GA4828@bnru02.bnr.st.com>
References: <1268886061-6382-1-git-send-email-rabin.vincent@stericsson.com>
	<1268890402-31618-1-git-send-email-rabin.vincent@stericsson.com>
	<4BAF969B.1030608@windriver.com>
	<20100408134135.GA4828@bnru02.bnr.st.com>
Message-ID: <20100409222814.EBAE019F36@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Rabin VINCENT,

In message <20100408134135.GA4828@bnru02.bnr.st.com> you wrote:
> On Sun, Mar 28, 2010 at 07:49:15PM +0200, Tom wrote:
> > Rabin Vincent wrote:
> > > +	/* UART2 */
> > > +	nmk_gpio_af(29, GPIO_ALT_C);
> > > +	nmk_gpio_af(30, GPIO_ALT_C);
> > 
> > Change these to immediates to logical #define's
> 
> I've changed this in the other places you mentioned, but for these
> GPIOs, I'd prefer to use the pin numbers directly.

Maybe you do, but we don't. Please don't use magic numbers.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Tell the truth and run."                          - Yugoslav proverb