Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O0PHB-0006KL-VU
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 21:14:22 -0400
Received: from [140.186.70.92] (port=39124 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O0PHA-0006JZ-Ii
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 21:14:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1O0PH8-0005QM-BN
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 21:14:20 -0400
Received: from hall.aurel32.net ([88.191.82.174]:50564)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1O0PH8-0005QG-2f
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 21:14:18 -0400
Date: Sat, 10 Apr 2010 02:22:30 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only
Message-ID: <20100410002230.GT21042@volta.aurel32.net>
References: <20100407115806.GC12452@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20100407115806.GC12452@lst.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

On Wed, Apr 07, 2010 at 01:58:06PM +0200, Christoph Hellwig wrote:
> bdrv_open already takes care of this for us.

Thanks, applied.

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: qemu/block/raw-posix.c
> ===================================================================
> --- qemu.orig/block/raw-posix.c	2010-04-07 13:50:16.573261199 +0200
> +++ qemu/block/raw-posix.c	2010-04-07 13:50:25.180005926 +0200
> @@ -142,7 +142,6 @@ static int raw_open_common(BlockDriverSt
>          s->open_flags |= O_RDWR;
>      } else {
>          s->open_flags |= O_RDONLY;
> -        bs->read_only = 1;
>      }
>  
>      /* Use O_DSYNC for write-through caching, no flags for write-back caching,
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net