Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O1oO3-0002fL-FY for qemu-devel@nongnu.org; Tue, 13 Apr 2010 18:15:15 -0400 Received: from [140.186.70.92] (port=45473 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1oO2-0002Yk-2Z for qemu-devel@nongnu.org; Tue, 13 Apr 2010 18:15:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O1oBR-0004WC-CG for qemu-devel@nongnu.org; Tue, 13 Apr 2010 18:02:14 -0400 Received: from hall.aurel32.net ([88.191.82.174]:33104) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1oBR-0004W4-4y for qemu-devel@nongnu.org; Tue, 13 Apr 2010 18:02:13 -0400 Date: Wed, 14 Apr 2010 00:02:10 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] vhost-net: disable mergeable buffers Message-ID: <20100413220210.GB24116@volta.aurel32.net> References: <20100404143655.GA7731@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100404143655.GA7731@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Sun, Apr 04, 2010 at 05:36:55PM +0300, Michael S. Tsirkin wrote: > vhost in current kernels doesn't support mergeable buffers. > Disable this feature if vhost is enabled, until such > support is implemented. > > Signed-off-by: Michael S. Tsirkin Thanks, applied. > --- > hw/vhost_net.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/vhost_net.c b/hw/vhost_net.c > index 39643f1..2e292ee 100644 > --- a/hw/vhost_net.c > +++ b/hw/vhost_net.c > @@ -51,6 +51,7 @@ unsigned vhost_net_get_features(struct vhost_net *net, unsigned features) > if (!(net->dev.features & (1 << VIRTIO_RING_F_INDIRECT_DESC))) { > features &= ~(1 << VIRTIO_RING_F_INDIRECT_DESC); > } > + features &= ~(1 << VIRTIO_NET_F_MRG_RXBUF); > return features; > } > > -- > 1.7.0.2.280.gc6f05 > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net