Date: Sun, 18 Apr 2010 21:37:18 -0500
From: Ryan Harper <ryanh@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH][STABLE] Add qerror message if the	'change'
	target filename can't be opened
Message-ID: <20100419023718.GR24351@us.ibm.com>
References: <20100409124638.GY24351@us.ibm.com>
	<20100418204711.GA22688@hall.aurel32.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100418204711.GA22688@hall.aurel32.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Ryan Harper <ryanh@us.ibm.com>, qemu-devel@nongnu.org

* Aurelien Jarno <aurelien@aurel32.net> [2010-04-18 15:55]:
> On Fri, Apr 09, 2010 at 07:46:38AM -0500, Ryan Harper wrote:
> > Currently when using the change command to switch the file in the cd drive
> > the command doesn't complain if the file doesn't exit or can't be opened
> > and the drive keeps the existing image.  This patch adds a qerror_report
> > call to print a message out indicating the failure.  This error message
> > can be used to catch failures.
> 
> Applied to HEAD, however it doesn't apply to stable. Is it really needed
> here?

No, you're right.  Qemu doesnt' segfault or anything bad.  That and the
qerror class for open file failed isn't in stable so we'd have to pull
that new code in (it's small, like 7 lines.  Anyhow, I have the patches,
but I agree that they aren't necessary for stable.

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com