Return-Path: Received: from ksp.mff.cuni.cz ([195.113.26.206]:52859 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751574Ab0DTNg7 (ORCPT ); Tue, 20 Apr 2010 09:36:59 -0400 Date: Tue, 20 Apr 2010 15:36:51 +0200 From: Pavel Machek Subject: Re: [PATCH 3/5] arm: msm: smd: convert unsigned addr to unsigned long Message-ID: <20100420133651.GB8670@ucw.cz> References: <> <1271700189-8376-3-git-send-email-dwalker@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1271700189-8376-3-git-send-email-dwalker@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Daniel Walker Cc: linux-arm-msm@vger.kernel.org, dima@android.com On Mon 2010-04-19 11:03:07, Daniel Walker wrote: > "unsigned" translates to "unsigned int", but this value holds an > address. We always want to use unsigned long for addresses since > it will change size to fit the machine. > > This just convert the one address holder to unsigned long. > > Signed-off-by: Daniel Walker ack. > --- > arch/arm/mach-msm/smd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c > index 6237a6c..4dd0d08 100644 > --- a/arch/arm/mach-msm/smd.c > +++ b/arch/arm/mach-msm/smd.c > @@ -867,9 +867,9 @@ static irqreturn_t smsm_irq_handler(int irq, void *data) > int smsm_change_state(enum smsm_state_item item, > uint32_t clear_mask, uint32_t set_mask) > { > + unsigned long addr = smd_info.state + item * 4; > unsigned long flags; > unsigned state; > - unsigned addr = smd_info.state + item * 4; > > if (!smd_info.ready) > return -EIO; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html