Date: Tue, 20 Apr 2010 15:37:19 +0200
From: Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 5/5] arm: msm: smd: fix SMD modem processor sync
 condition
Message-ID: <20100420133718.GB13050@ucw.cz>
References: <>
 <1271700189-8376-5-git-send-email-dwalker@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1271700189-8376-5-git-send-email-dwalker@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
To: Daniel Walker <dwalker@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, dima@android.com, Daniel Walker <c_dwalke@quicinc.com>

On Mon 2010-04-19 11:03:09, Daniel Walker wrote:
> From: Daniel Walker <c_dwalke@quicinc.com>
> 
> When booting up we need to wait for the modem processor to
> partially boot. This is because the modem processor does
> resource allocation for us. If we don't wait the modem won't
> honor our requests and we end up crashing or in an unknown
> state. This change just formalizes the waiting process.
...

> +/*
> + * We need to wait for the ARM9 to at least partially boot
> + * up before we can continue. Since the ARM9 does resource
> + * allocation, if we dont' wait we could end up crashing or in

typo.

> + * and unknown state. This function should be called early to
> + * wait on the ARM9.
> + */
> +void __init proc_comm_boot_wait(void)
> +{
> +	void __iomem *base = MSM_SHARED_RAM_BASE;
> + 
> +	proc_comm_wait_for(base + MDM_STATUS, PCOM_READY);
> + 
> +}

static inline, move it to header file?

> diff --git a/arch/arm/mach-msm/proc_comm.h b/arch/arm/mach-msm/proc_comm.h
> index 0f5cdd3..12da4ca 100644
> --- a/arch/arm/mach-msm/proc_comm.h
> +++ b/arch/arm/mach-msm/proc_comm.h
> @@ -16,6 +16,8 @@
>  #ifndef _ARCH_ARM_MACH_MSM_PROC_COMM_H_
>  #define _ARCH_ARM_MACH_MSM_PROC_COMM_H_
>  
> +#include <linux/init.h>
> +

...so that this is not needed?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html