From: Mark Fasheh Date: Fri, 23 Apr 2010 10:32:47 -0700 Subject: [Ocfs2-devel] [PATCH 1/3] ocfs2: add OCFS2_INODE_SKIP_ORPHAN_DIR flag and honor it in the inode wipe code In-Reply-To: <20100423173028.GN17187@wotan.suse.de> References: <201004221611.19307.lidongyang@novell.com> <20100423173028.GN17187@wotan.suse.de> Message-ID: <20100423173247.GO17187@wotan.suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On Fri, Apr 23, 2010 at 10:30:28AM -0700, Mark Fasheh wrote: > On Thu, Apr 22, 2010 at 04:11:19PM +0800, Li Dongyang wrote: > > currently in the error path of ocfs2_symlink and ocfs2_mknod, > > we just call iput with the inode we failed with, but the inode wipe code will > > complain because we don't add the inode to orphan dir. > > however, adding the inode to orphan dir requires additional transaction > > credits > > which is too heavy for an error path, so we just use the Actually, what's too heavy is the orphan dir locking. The transaction credits aren't really a problem in this case. Code's still good to go. You should update this description though. --Mark -- Mark Fasheh