From: Mike Frysinger Date: Mon, 26 Apr 2010 11:59:32 -0400 Subject: [U-Boot] [PATCH] mmc: add generic mmc spi driver In-Reply-To: <4BD5A513.100@wytron.com.tw> References: <1271991214-7937-1-git-send-email-thomas@wytron.com.tw> <201004250256.10907.vapier@gentoo.org> <4BD5A513.100@wytron.com.tw> Message-ID: <201004261159.35179.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 26 April 2010 10:37:07 Thomas Chou wrote: > I have moved spi slave setup so that we can change the cs on the fly. We > could add a subcommand, like, > > mmc_spi [bus:]cs > > Where should I place this command? in a new file in common dir or inside > the mmc_spi driver? i would keep the current board init hook you have currently so that the boards which do have static settings can leverage that, and have the mmc_spi command simply call that. i'd have the syntax be: mmc_spi [bus:]cs [hz [mode]] i'd have it be a dedicated command in common/ so that people can disable it if they dont want it. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100426/05a65066/attachment.pgp