From: Anton Vorontsov Subject: Re: [patch 1/6] gpiolib: introduce chip addition/removal notifier Date: Sun, 2 May 2010 20:59:12 +0400 Message-ID: <20100502165912.GA11300@oksana.dev.rtsoft.ru> References: <201004272111.o3RLBw1f020037@imap1.linux-foundation.org> <1272428830.24542.72.camel@pasglop> <20100430174240.GA29769@oksana.dev.rtsoft.ru> <20100430174609.GA31455@oksana.dev.rtsoft.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: bgat-uPd5UNENI//N9NzbbXoYwQ@public.gmane.org, dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org List-Id: devicetree@vger.kernel.org (Cc'ing devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org) On Sat, May 01, 2010 at 12:50:15AM -0600, Grant Likely wrote: > Not till now. Here's what I've been working on. It's based on my > test-devicetree branch. [...] > As you can see, I've pretty much come full circle on the adding > 'automatic' OF support to gpio chips. Originally (as you well know) I > was strongly opposed to any addition of OF code to the core gpiolib. > All of the notifier work was a response to that. > > However, now that I actually have played with the code and looked and > the issues deeply, I've got an entirely different opinion. ROFL :-D > (The fact > that OF support is being ported to more architectures is also a > factor.) Yeah, I guess without multi-arch OF effort such an OF+gpiolib integration would be very dubious. But as OF spreads to other architectures, and we already have of_node in the 'struct device'... I guess that makes sense now. > Anyway, please take a look. It works here with some small fixes (patches on the way). Tested with MCU (I2C), and QE GPIO (memory mapped) GPIO controllers. Thanks! -- Anton Vorontsov email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org irc://irc.freenode.net/bd2